[vlc-devel] [vlc-commits] contrib/ebml: fix variable order

Steve Lhomme robux4 at ycbcr.xyz
Tue Jul 23 12:52:53 CEST 2019


Reverted the 2 patches with approval of Felix. This loses the extra 
files we wanted to force.

The problem was the DBGOPTIMFLAGS were missing from the CXXFLAGS we used 
to create the new CXXFLAGS from EBML_CXXFLAGS. See patch named `contrib: 
make sure the debug flags are always set in the global CFLAGS`.

On 2019-07-23 11:54, Felix Paul Kühne wrote:
> vlc | branch: master | Felix Paul Kühne <felix at feepk.net> | Tue Jul 23 11:52:32 2019 +0200| [28a2031676cdd6b12576982a2b62e65f366f4d49] | committer: Felix Paul Kühne
> 
> contrib/ebml: fix variable order
> 
> Previously, the specific CXXFLAGS weren't respected so the visibility flags never applied.
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=28a2031676cdd6b12576982a2b62e65f366f4d49
> ---
> 
>   contrib/src/ebml/rules.mak | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/src/ebml/rules.mak b/contrib/src/ebml/rules.mak
> index 13c6bc2ffc..0f6fb65ec7 100644
> --- a/contrib/src/ebml/rules.mak
> +++ b/contrib/src/ebml/rules.mak
> @@ -20,6 +20,6 @@ ebml: libebml-$(EBML_VERSION).tar.xz .sum-ebml
>   EBML_CXXFLAGS := $(CXXFLAGS) $(PIC) -fexceptions -fvisibility=hidden
>   
>   .ebml: ebml toolchain.cmake
> -	cd $< && $(HOSTVARS_PIC) CXXFLAGS="$(EBML_CXXFLAGS)" $(CMAKE) -DBUILD_SHARED_LIBS=OFF -DENABLE_WIN32_IO=OFF
> +	cd $< && CXXFLAGS="$(EBML_CXXFLAGS)" $(HOSTVARS_PIC) $(CMAKE) -DBUILD_SHARED_LIBS=OFF -DENABLE_WIN32_IO=OFF
>   	cd $< && $(MAKE) install
>   	touch $@
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
> 


More information about the vlc-devel mailing list