[vlc-devel] [PATCH 2/2] audio_filter: add RNNoise denoiser filter

[Tristan Matthews]

On Fri, Jul 26, 2019 at 9:22 AM Marvin Scholz <epirat07 at gmail.com> wrote:
>
> On 26 Jul 2019, at 15:19, Tristan Matthews wrote:
>
> > Hi,
> >
> > On Fri, Jul 26, 2019 at 9:02 AM Marvin Scholz <epirat07 at gmail.com> wrote:
> >>
> >>
> >>
> >> On 26 Jul 2019, at 14:45, Tristan Matthews wrote:
> >>
> >>> On Fri, Jul 26, 2019 at 3:03 AM Marvin Scholz <epirat07 at gmail.com>
> >>> wrote:
> >>>>
> >>>> On 26 Jul 2019, at 7:19, Tristan Matthews wrote:
> >>>>
> >>>>> ---
> >>>>>  NEWS                             |   3 +
> >>>>>  configure.ac                     |  15 +++++
> >>>>>  modules/audio_filter/Makefile.am |   7 ++
> >>>>>  modules/audio_filter/rnnoise.c   | 109
> >>>>> +++++++++++++++++++++++++++++++
> >>>>>  po/POTFILES.in                   |   1 +
> >>>>>  5 files changed, 135 insertions(+)
> >>>>>  create mode 100644 modules/audio_filter/rnnoise.c
> >>>>>
> >>>>> diff --git a/NEWS b/NEWS
> >>>>> index 0f4f6d74c0..e364df7abe 100644
> >>>>> --- a/NEWS
> >>>>> +++ b/NEWS
> >>>>> @@ -71,6 +71,9 @@ Video output:
> >>>>>   * Remove RealRTSP plugin
> >>>>>   * Remove Real demuxer plugin
> >>>>>
> >>>>> +Audio filter:
> >>>>> + * Add RNNoise recurrent neural network denoiser
> >>>>> +
> >>>>>  Video filter:
> >>>>>   * Update yadif
> >>>>>   * Remove remote OSD plugin
> >>>>> diff --git a/configure.ac b/configure.ac
> >>>>> index ac818d8b83..c0f1f09dcb 100644
> >>>>> --- a/configure.ac
> >>>>> +++ b/configure.ac
> >>>>> @@ -2901,6 +2901,21 @@ AS_IF([test "${enable_speex}" != "no"], [
> >>>>>  ])
> >>>>>  AM_CONDITIONAL([HAVE_SPEEXDSP], [test "$have_speexdsp" = "yes"])
> >>>>>
> >>>>> +AC_ARG_ENABLE([rnnoise],
> >>>>> +  AS_HELP_STRING([--enable-rnnoise],
> >>>>> +    [RNNoise denoiser filter (default auto)]))
> >>>>> +have_rnnoise="no"
> >>>>> +AS_IF([test "${enable_rnnoise}" != "no"], [
> >>>>> +  PKG_CHECK_MODULES([RNNOISE], [rnnoise], [
> >>>>> +    have_rnnoise="yes"
> >>>>> +  ], [
> >>>>> +    AS_IF([test "x${enable_rnnoise}" != "x"], [
> >>>>> +      AC_MSG_ERROR([$RNNOISE_PKG_ERRORS.])
> >>>>> +    ])
> >>>>> +  ])
> >>>>> +])
> >>>>> +AM_CONDITIONAL([HAVE_RNNOISE], [test "${have_rnnoise}" = "yes"])
> >>>>
> >>>> Can't you use
> >>>>
> >>>> PKG_ENABLE_MODULES_VLC(VARIABLE-PREFIX,
> >>>>                           VLC_MODULE_NAME  dnl (if empty, same as
> >>>> VARIABLE-PREFIX)
> >>>>                           PKG MODULES,
> >>>>                           [DESCRIPTION], [DEFAULT],
> >>>>                           [EXTRA_CFLAGS], [EXTRA_LIBS],
> >>>> [EXTRA_CPPFLAGS]
> >>>>
> >>>> here, i.e.:
> >>>>
> >>>> PKG_ENABLE_MODULES_VLC([RNNOISE], [], [RNNoise denoiser filter],
> >>>> [auto])
> >>>
> >>> I had tried something like this initially but the plugin was being
> >>> built unconditionally.
> >>>
> >>
> >> You maybe forgot to adjust the Makefile.am too, like this:
> >>
> >> librnnoise_plugin_la_SOURCES = audio_filter/rnnoise.c
> >> librnnoise_plugin_la_CFLAGS = $(AM_CFLAGS) $(RNNOISE_CFLAGS)
> >> librnnoise_plugin_la_LIBADD = $(RNNOISE_LIBS) $(LIBM)
> >>
> >> audio_filter_LTLIBRARIES += $(LTLIBrnnoise)
> >> EXTRA_LTLIBRARIES += librnnoise_plugin.la
> >>
> >
> > I had also tried that, and had the opposite problem, where the plugin
> > was never being built.
>
> Well we use that for quite a few plugins, so it should work fine…
> Weird.

Ok think I got it, was a combination of missing LDFLAGS and
"not-clean-enough" rebuilds.