[vlc-devel] [PATCH] qt: add missing override specifier

Alexandre Janniaux ajanni at videolabs.io
Fri Jul 26 22:33:58 CEST 2019


Hi,

LGTM,

Regards,

--
Alexandre Janniaux
VideoLabs

On Fri, Jul 26, 2019 at 09:32:46PM +0200, Marvin Scholz wrote:
> ---
>  modules/gui/qt/components/extended_panels.hpp             | 2 +-
>  modules/gui/qt/components/voutwindow/qvoutwindowdummy.hpp | 2 +-
>  modules/gui/qt/dialogs/plugins.hpp                        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/modules/gui/qt/components/extended_panels.hpp b/modules/gui/qt/components/extended_panels.hpp
> index ee2a61cf22..b36659afd6 100644
> --- a/modules/gui/qt/components/extended_panels.hpp
> +++ b/modules/gui/qt/components/extended_panels.hpp
> @@ -165,7 +165,7 @@ protected:
>      float initialValue() Q_DECL_OVERRIDE;
>      int index;
>      QStringList getBandsFromAout() const;
> -    void writeToConfig();
> +    void writeToConfig() override;
>
>  public slots:
>      void onValueChanged( int i ) Q_DECL_OVERRIDE;
> diff --git a/modules/gui/qt/components/voutwindow/qvoutwindowdummy.hpp b/modules/gui/qt/components/voutwindow/qvoutwindowdummy.hpp
> index 5fbceddc71..7a8a395719 100644
> --- a/modules/gui/qt/components/voutwindow/qvoutwindowdummy.hpp
> +++ b/modules/gui/qt/components/voutwindow/qvoutwindowdummy.hpp
> @@ -44,7 +44,7 @@ public:
>
>      VideoSurfaceProvider* getVideoSurfaceProvider() override;
>
> -    bool setupVoutWindow(vout_window_t* voutWindow);
> +    bool setupVoutWindow(vout_window_t* voutWindow) override;
>
>  private:
>      VideoSurfaceProviderDummy* m_surfaceProvider = nullptr;
> diff --git a/modules/gui/qt/dialogs/plugins.hpp b/modules/gui/qt/dialogs/plugins.hpp
> index 014016d9cc..12705a91d2 100644
> --- a/modules/gui/qt/dialogs/plugins.hpp
> +++ b/modules/gui/qt/dialogs/plugins.hpp
> @@ -141,7 +141,7 @@ private slots:
>  private:
>      AddonsTab( intf_thread_t *p_intf );
>      virtual ~AddonsTab();
> -    bool eventFilter ( QObject * watched, QEvent * event );
> +    bool eventFilter ( QObject * watched, QEvent * event ) override;
>
>      enum
>      {
> --
> 2.19.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list