[vlc-devel] [PATCH 1/7] Add mDNS Services Advertisement submodule (stub)

[Roland Bewick]

On 26/07/2019 11:03 PM, Marvin Scholz wrote:
>
>
> On 26 Jul 2019, at 17:55, Rémi Denis-Courmont wrote:
>
>>     Hi,
>>
>> Le perjantaina 26. heinäkuuta 2019, 14.54.58 EEST Marvin Scholz a 
>> écrit :
>>> I think in general what you want is to allow individual plugins to use
>>> the service advertisement module(s) to advertise themselves or add
>>> advertisements.
>>
>> We already have a service announcement API, or leftovers of it, in 
>> the VLC
>> core. It was not exactly a great success. I think the take-away is 
>> that the
>> advertised service types and the advertisement protocols are too tightly
>> coupled to make a generic API.
>>
>> You might be able to make a generic Bonjour API, but I don't think we 
>> should
>> again try and fail to make a really generic API.
>
> Yeah I doubt it is possible to make a truly generic API for that, as 
> it is
> probably impossible to abstract in a way that works across the different
> discovery protocols / technologies.


In that case it sounds like a good idea to keep going with this simple / 
inflexible module for starters so that we can at least get something 
working.


>
>>
>>> For example if the VLC http module only listens on v4 only, you do not
>>> want to announce the v6 address too.
>>
>> The HTTP server is of course dual-stack, almost from the beginning. 
>> But I
>> don't think you want to promote the current HTTP interface and remote 
>> control
>> interfaces anyway. They are both ridiculously insecure and unreliable/
>> unstable.


It seems like the main purpose of this new services advertisement module 
is to promote those insecure/unreliable/unstable interfaces, since 
that's all that's available right now :-/


>
> Sure, this was just an example of one possible case where blindly 
> announcing
> all addresses could be the wrong thing to do. Of course for most 
> services in
> VLC this does not matter that much…


I think libmicrodns is designed to only serve on one address family at a 
time, so we'd have to launch the module twice with different 
configuration to support both IPv4 and IPv6 simultaneously if someone 
wants to do that.

Given the services advertisement module would default to using IPV6, 
maybe something like this?

vlc --services-advertisement mdns:mdns {address-family=v4}


>
>>
>> -- 
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel