[vlc-devel] [PATCH] codec/videotoolbox: Fix uninitialized pts in late start case

[Marvin Scholz]

On 29 Jul 2019, at 10:40, Thomas Guillem wrote:

> On Sun, Jul 28, 2019, at 13:14, Marvin Scholz wrote:
>> ---
>>  modules/codec/videotoolbox.m | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/modules/codec/videotoolbox.m 
>> b/modules/codec/videotoolbox.m
>> index b01b5d4511..393d8247d4 100644
>> --- a/modules/codec/videotoolbox.m
>> +++ b/modules/codec/videotoolbox.m
>> @@ -1920,6 +1920,9 @@ static int DecodeBlock(decoder_t *p_dec, 
>> block_t *p_block)
>>          if (!p_block)
>>              return VLCDEC_SUCCESS;
>>      }
>> +    if (!p_sys->session /* Late Start */) {
>> +        PtsInit(p_dec);
>> +    }
>
> Should the PtsInit() call been removed from StartVideoToolbox() ?

Maybe, yeah, but I do not know the best place to always do it.
Just removing it there would break the non-late-start cases.

>>
>>      frame_info_t *p_info = CreateReorderInfo(p_dec, p_block);
>>      if(unlikely(!p_info))
>> -- 
>> 2.19.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel