[vlc-devel] [PATCH v2] codec/videotoolbox: Fix uninitialized pts in late start case

[Thomas Guillem]

On Mon, Jul 29, 2019, at 11:20, Marvin Scholz wrote:
> ---
>  modules/codec/videotoolbox.m | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/codec/videotoolbox.m b/modules/codec/videotoolbox.m
> index b01b5d4511..111c58fee1 100644
> --- a/modules/codec/videotoolbox.m
> +++ b/modules/codec/videotoolbox.m
> @@ -1269,8 +1269,6 @@ static int StartVideoToolbox(decoder_t *p_dec)
>      if (HandleVTStatus(p_dec, status, NULL) != VLC_SUCCESS)
>          return VLC_EGENERIC;
>  
> -    PtsInit(p_dec);
> -
>      return VLC_SUCCESS;
>  }
>  
> @@ -1448,6 +1446,8 @@ static int OpenDecoder(vlc_object_t *p_this)
>                          (char *)&p_dec->fmt_in.i_codec);
>      else
>          CloseDecoder(p_this);
> +
> +    PtsInit(p_dec);

Don't do PtsInit() in the CloseDecoder() path

Could you squash this commit and the first one into one commit ?

>      return i_ret;
>  }
>  
> -- 
> 2.19.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel