[vlc-devel] [PATCH 12/14] filter_chain: add a default implementation for the video_allocator
remi at remlab.net
Mon Jul 29 19:50:23 CEST 2019
Le perjantaina 26. heinäkuuta 2019, 9.18.37 EEST Steve Lhomme a écrit :
> On 2019-07-25 19:08, Rémi Denis-Courmont wrote:
> > Le torstaina 25. heinäkuuta 2019, 13.34.11 EEST Steve Lhomme a écrit :
> >> At some point NULL should not be allowed there.
> > I don't think we should have allocation callbacks in filters at all
> > anymore. We got rid of them for audio years ago.
> It cannot work for filters outputting GPU surfaces.
I don't see the causality there?
Such a filter would need to get the video context, if it needs to allocate
surfaces. In fact, a GPU filter might need the video context anyway to do
processing, even if it operates "in-place" and does not allocate GPU surfaces.
Why would the filter need to allocate through the callback? And if so, how will
it work for filters that do not allocate pictures? (VDPAU already has such
Just because picture_NewFromFormat() does not work does not imply that
filter_NewPicture() is required, or even that it works, IMU.
More information about the vlc-devel