[vlc-devel] [PATCH] vout/ios: fix leak

Alexandre Janniaux ajanni at videolabs.io
Tue Jul 30 10:16:00 CEST 2019


Hi,

LGTM, as vout_display_New calls vlc_objres_clear.

Regards,
--
Alexandre Janniaux
VideoLabs

On Mon, Jul 29, 2019 at 03:18:28PM +0200, Thomas Guillem wrote:
> This partially reverts commit 9db9c1121193c2a201eb37e9858a603509f684a6.
> ---
>  modules/video_output/ios.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/video_output/ios.m b/modules/video_output/ios.m
> index b5456cb3e8..2816476836 100644
> --- a/modules/video_output/ios.m
> +++ b/modules/video_output/ios.m
> @@ -147,7 +147,7 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
>      if (vout_display_cfg_IsWindowed(cfg))
>          return VLC_EGENERIC;
>
> -    vout_display_sys_t *sys = calloc(1, sizeof(*sys));
> +    vout_display_sys_t *sys = vlc_obj_calloc(vd, 1, sizeof(*sys));
>
>      if (!sys)
>          return VLC_ENOMEM;
> --
> 2.20.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list