[vlc-devel] [PATCH 12/14] filter_chain: add a default implementation for the video_allocator

Rémi Denis-Courmont remi at remlab.net
Tue Jul 30 18:52:55 CEST 2019


Le tiistaina 30. heinäkuuta 2019, 9.57.24 EEST Steve Lhomme a écrit :
> > If all GPU filters are using the video context, it means that you can't
> > have
> All filters have a video context, even if it's a "CPU" video context. A
> NULL video context will not be allowed. It wouldn't make sense, just
> like an empty video format doesn't make sense. It's also the best
> candidate to carry the decoder device along the whole filter chain (see
> previous answer).

Sure it makes sense. Regular RAM has no reason to have a video context, except 
maybe for convenience.

> Yes, at the very least the last filter in a chain must get pictures from
> the outside, not create its own.

I completely disagree, and that's not how push model was designed.

Push model means filters and converters allocate their *output* picture, just 
like decoders do. Nothing else makes sense - the downstream has to handle the 
case that there are no filters and the decoders pushes its pictures, so it 
might as well do the same with filters.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list