[vlc-devel] [PATCH 03/12] dvdnav: Notify of title changes when dvdnav notifies us

[Francois Cartegnie]

Le 31/07/2019 à 11:20, Hugo Beauzée-Luyssen a écrit :
> Otherwise the title is not "ready" and we can't seek in it until a few
> more blocks are demuxed

Likely was designed to handle data from end of cell, that's why the
title update is postponed and done in Demux()

> ---
>  modules/access/dvdnav.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c
> index 4c240ecda5..1cbf2a40a2 100644
> --- a/modules/access/dvdnav.c
> +++ b/modules/access/dvdnav.c
> @@ -628,10 +628,6 @@ static int Control( demux_t *p_demux, int i_query, va_list args )
>                      return VLC_EGENERIC;
>                  }
>              }
> -
> -            p_sys->updates |= INPUT_UPDATE_TITLE | INPUT_UPDATE_SEEKPOINT;
> -            p_sys->cur_title = i;
> -            p_sys->cur_seekpoint = 0;
>              RandomAccessCleanup( p_sys );
>              return VLC_SUCCESS;
>  
> @@ -934,9 +930,6 @@ static int Demux( demux_t *p_demux )
>  
>      case DVDNAV_VTS_CHANGE:
>      {
> -        int32_t i_title = 0;
> -        int32_t i_part  = 0;
> -
>          dvdnav_vts_change_event_t *event = (dvdnav_vts_change_event_t*)packet;
>          msg_Dbg( p_demux, "DVDNAV_VTS_CHANGE" );
>          msg_Dbg( p_demux, "     - vtsN=%d", event->new_vtsN );
> @@ -985,17 +978,6 @@ static int Demux( demux_t *p_demux )
>              p_sys->sar.i_den = 0;
>              break;
>          }
> -
> -        if( dvdnav_current_title_info( p_sys->dvdnav, &i_title,
> -                                       &i_part ) == DVDNAV_STATUS_OK )
> -        {
> -            if( i_title >= 0 && i_title < p_sys->i_title &&
> -                p_sys->cur_title != i_title )
> -            {
> -                p_sys->updates |= INPUT_UPDATE_TITLE;
> -                p_sys->cur_title = i_title;
> -            }
> -        }
>          break;
>      }
>  
> 


-- 
Francois Cartegnie
VideoLAN - VLC Developer