[vlc-devel] [PATCH 2/2] vout: remove always false is_slow

[Steve Lhomme]

On 2019-07-31 12:21, Steve Lhomme wrote:
> We don't need it anymore.
> ---
>   include/vlc_vout_display.h      | 1 -
>   src/video_output/video_output.c | 2 +-
>   src/video_output/vout_wrapper.c | 2 +-
>   3 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/vlc_vout_display.h b/include/vlc_vout_display.h
> index cc5dbd2032..80f813ba87 100644
> --- a/include/vlc_vout_display.h
> +++ b/include/vlc_vout_display.h
> @@ -105,7 +105,6 @@ typedef struct vout_display_cfg {
>    *
>    */
>   typedef struct {
> -    bool is_slow;                           /* The picture memory has slow read/write */
>       bool has_pictures_invalid;              /* Can handle VOUT_DISPLAY_RESET_PICTURES */
>       bool can_scale_spu;                     /* Handles subpictures with a non default zoom factor */
>       const vlc_fourcc_t *subpicture_chromas; /* List of supported chromas for subpicture rendering. */
> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
> index 619ccbf194..9e93243cec 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -1033,7 +1033,7 @@ static int ThreadDisplayRenderPicture(vout_thread_t *vout, bool is_forced)
>       //the source format.
>       const bool do_early_spu = !do_dr_spu &&
>                                  vd->source.orientation == ORIENT_NORMAL &&
> -                              (vd->info.is_slow || do_snapshot);
> +                               do_snapshot;

If fact we don't need to test do_snapshot anymore. If do_dr_spu can only 
be false, if do_snapshot is true.

>       const vlc_fourcc_t *subpicture_chromas;
>       video_format_t fmt_spu;
> diff --git a/src/video_output/vout_wrapper.c b/src/video_output/vout_wrapper.c
> index 24ef0e0448..9ac6e2eab0 100644
> --- a/src/video_output/vout_wrapper.c
> +++ b/src/video_output/vout_wrapper.c
> @@ -83,7 +83,7 @@ vout_display_t *vout_OpenWrapper(vout_thread_t *vout,
>       sys->display_pool = NULL;
>   
>       const bool use_dr = !vout_IsDisplayFiltered(vd);
> -    const bool allow_dr = !vd->info.has_pictures_invalid && !vd->info.is_slow && use_dr;
> +    const bool allow_dr = !vd->info.has_pictures_invalid && use_dr;
>       const unsigned private_picture  = 4; /* XXX 3 for filter, 1 for SPU */
>       const unsigned decoder_picture  = 1 + sys->dpb_size;
>       const unsigned kept_picture     = 1; /* last displayed picture */
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>