[vlc-devel] [PATCH] contrib: Redirect stderr to stdout for clang check

[Marvin Scholz]

On 1 Jun 2019, at 11:44, Alexandre Janniaux wrote:

> Hi,
>
> If we don't care about errors, because it's only for detection
> purpose, can't we discard the stderr stream instead ?

It is not only about errors. The mentioned stuff that is
printed is not an error.

I have no idea why they print some things on stderr and some
on stdout. Especially the "Configured with..." line is only
printed if clang is called with the gcc alias, so maybe
thats for gcc compatibility, not sure.

Anyway, I do not care much if we discard it or not, so I would
be fine with either solution.

>
> On Fri, May 31, 2019 at 10:35:15PM +0200, Marvin Scholz wrote:
>> This prevents confusing messages on stderr like:
>>
>> "Configured with: …"
>> ---
>>  contrib/src/main.mak | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 8944a5a1d7..97c3a8ab8a 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -175,7 +175,7 @@ EXTRA_CFLAGS += -DWINSTORECOMPAT
>>  EXTRA_LDFLAGS += -lwinstorecompat
>>  endif
>>
>> -ifneq ($(findstring clang, $(shell $(CC) --version)),)
>> +ifneq ($(findstring clang, $(shell $(CC) --version 2>&1)),)
>>  HAVE_CLANG := 1
>>  endif
>>
>> --
>> 2.20.1 (Apple Git-117)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel