[vlc-devel] [PATCH] libvlc: remove the crop getter

Steve Lhomme robux4 at ycbcr.xyz
Tue Jun 4 11:30:06 CEST 2019


The host can keep the value it sets, and there's no way to change the value in
libvlc otherwise.
---
 include/vlc/libvlc_media_player.h | 8 --------
 lib/libvlc.sym                    | 1 -
 lib/video.c                       | 5 -----
 3 files changed, 14 deletions(-)

diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
index 6616bc4f59..c7f30af588 100644
--- a/include/vlc/libvlc_media_player.h
+++ b/include/vlc/libvlc_media_player.h
@@ -1651,14 +1651,6 @@ LIBVLC_API
 void libvlc_chapter_descriptions_release( libvlc_chapter_description_t **p_chapters,
                                           unsigned i_count );
 
-/**
- * Get current crop filter geometry.
- *
- * \param p_mi the media player
- * \return the crop filter geometry or NULL if unset
- */
-LIBVLC_API char *libvlc_video_get_crop_geometry( libvlc_media_player_t *p_mi );
-
 /**
  * Set new crop filter geometry.
  *
diff --git a/lib/libvlc.sym b/lib/libvlc.sym
index 8255d47cef..5eb1acdb4a 100644
--- a/lib/libvlc.sym
+++ b/lib/libvlc.sym
@@ -213,7 +213,6 @@ libvlc_toggle_fullscreen
 libvlc_track_description_list_release
 libvlc_video_get_adjust_float
 libvlc_video_get_adjust_int
-libvlc_video_get_crop_geometry
 libvlc_video_get_size
 libvlc_video_get_cursor
 libvlc_video_get_logo_int
diff --git a/lib/video.c b/lib/video.c
index 366afb1d6d..ac93ffe75d 100644
--- a/lib/video.c
+++ b/lib/video.c
@@ -370,11 +370,6 @@ int libvlc_video_set_spu_delay( libvlc_media_player_t *p_mi,
     return 0;
 }
 
-char *libvlc_video_get_crop_geometry (libvlc_media_player_t *p_mi)
-{
-    return var_GetNonEmptyString (p_mi, "crop");
-}
-
 void libvlc_video_set_crop_geometry( libvlc_media_player_t *p_mi,
                                      const char *psz_geometry )
 {
-- 
2.17.1



More information about the vlc-devel mailing list