[vlc-devel] [PATCH] input: fix the rate sign check

[Rémi Denis-Courmont]

Le keskiviikkona 5. kesäkuuta 2019, 14.54.53 EEST Steve Lhomme a écrit :
> fabsf( param.val.f_float ) cannot be negative.
> 
> Compilers should warn about this.
> ---
>  src/input/input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/input/input.c b/src/input/input.c
> index a6116ab8e7..97ee9a6bb6 100644
> --- a/src/input/input.c
> +++ b/src/input/input.c
> @@ -1920,7 +1920,7 @@ static bool Control( input_thread_t *p_input,
>          {
>              /* Get rate and direction */
>              float rate = fabsf( param.val.f_float );
> -            int i_rate_sign = rate < 0 ? -1 : 1;
> +            int i_rate_sign = param.val.f_float < 0 ? -1 : 1;
> 
>              /* Check rate bound */
>              if( rate > INPUT_RATE_MAX )

Or don't reinvent the wheel at all. There is signbit().

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/