[vlc-devel] [PATCH 6/7 v2] contrib: Move HAVE_WIN64 for aarch64 to bootstrap

Marvin Scholz epirat07 at gmail.com
Wed Jun 5 22:53:38 CEST 2019


On 5 Jun 2019, at 16:59, Rémi Denis-Courmont wrote:

> That seems very inconsistent to me.

Indeed, after having another look it seems the HAVE_WIN64 in bootstrap 
is
completely redundant, will submit a new patchset.

>
> Le 5 juin 2019 17:15:52 GMT+03:00, Marvin Scholz <epirat07 at gmail.com> 
> a écrit :
>> This is consistent with where it is already set for amd64 and x86_64.
>> ---
>> contrib/bootstrap    | 2 +-
>> contrib/src/main.mak | 3 ---
>> 2 files changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/contrib/bootstrap b/contrib/bootstrap
>> index c2f9adb778..7cb103a404 100755
>> --- a/contrib/bootstrap
>> +++ b/contrib/bootstrap
>> @@ -369,7 +369,7 @@ case "${OS}" in
>> 				;;
>> 		esac
>> 		case "${HOST}" in
>> -			amd64*|x86_64*)
>> +			amd64*|x86_64*|aarch64*)
>> 				add_make_enabled "HAVE_WIN64"
>> 				;;
>> 		esac
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 8944a5a1d7..a37fc14c5c 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -41,9 +41,6 @@ ARCH := $(shell $(SRC)/get-arch.sh $(HOST))
>> ifeq ($(ARCH)-$(HAVE_WIN32),x86_64-1)
>> HAVE_WIN64 := 1
>> endif
>> -ifeq ($(ARCH)-$(HAVE_WIN32),aarch64-1)
>> -HAVE_WIN64 := 1
>> -endif
>>
>> ifdef HAVE_CROSS_COMPILE
>> need_pkg = 1
>> -- 
>> 2.20.1 (Apple Git-117)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté._______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list