[vlc-devel] [PATCH v4 0/9] Contrib cleanups
Marvin Scholz
epirat07 at gmail.com
Tue Jun 11 21:46:33 CEST 2019
This is anoter (hopefully the last) iteration on my contrib
cleanup patchset.
- It removes a format string for printf in the bootstrap script.
- Aditionally I discovered that the use fo eval in my meson
crossfile generation script was harmful and allowed for
code injection by putting them in CFLAGS or other env
variables that got passed to eval. To fix that, I've
investigated different solutions, though as none was
really satisfying and made the script quite complex and
hard to read I instead rewote the script as a python
script.
IMO using Python should be no problem, as meson itself
anyway requires python and the crossfile is only generated
if actually needed.
Marvin Scholz (9):
contrib/bootstrap: Fix indentation
contrib/bootstrap: Fix case order for arm64 check for darwin
contrib/bootstrap: Fix case order for arm64 check for android
contrib/bootstrap: Use add_make instead of echo redirect
contrib/bootstrap: Replace echo -n with printf
contrib/bootstrap: Remove redundant HAVE_WIN64 check
contrib: Rework meson crossfile generation
contrib: not pass HOSTVARS to meson when cross-compiling
contrib: Discard stderr when checking for clang
contrib/bootstrap | 143 ++++++++++++++---------------
contrib/src/gen-meson-crossfile.py | 52 +++++++++++
contrib/src/main.mak | 66 +++++--------
3 files changed, 143 insertions(+), 118 deletions(-)
create mode 100755 contrib/src/gen-meson-crossfile.py
--
2.20.1 (Apple Git-117)
More information about the vlc-devel
mailing list