[vlc-devel] [PATCH] aout/ios: Fix missing add_sw_gain macro

[Thomas Guillem]

On Thu, Jun 13, 2019, at 03:32, Marvin Scholz wrote:
> Without that, the gain option would be missing, causing an assertion
> when calling var_InheritFloat in aout_SoftVolumeInit.
> ---
>  modules/audio_output/audiounit_ios.m | 28 +++++++++++++---------------
>  1 file changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/modules/audio_output/audiounit_ios.m 
> b/modules/audio_output/audiounit_ios.m
> index ea555c0c14..bea6af2091 100644
> --- a/modules/audio_output/audiounit_ios.m
> +++ b/modules/audio_output/audiounit_ios.m
> @@ -31,21 +31,6 @@
>  #import <AVFoundation/AVFoundation.h>
>  #import <mach/mach_time.h>
>  
> -#pragma mark -
> -#pragma mark local prototypes & module descriptor
> -
> -static int  Open  (vlc_object_t *);
> -static void Close (vlc_object_t *);
> -
> -vlc_module_begin ()
> -    set_shortname("audiounit_ios")
> -    set_description("AudioUnit output for iOS")
> -    set_capability("audio output", 101)
> -    set_category(CAT_AUDIO)
> -    set_subcategory(SUBCAT_AUDIO_AOUT)
> -    set_callbacks(Open, Close)
> -vlc_module_end ()

NIT: it should be split in 2 commit: one that remove forward declaration, one that add add_sw_gain()

> -
>  #pragma mark -
>  #pragma mark private declarations
>  
> @@ -647,3 +632,16 @@ static int DeviceSelect(audio_output_t *p_aout, 
> const char *psz_id)
>      ca_Open(aout);
>      return VLC_SUCCESS;
>  }
> +
> +#pragma mark -
> +#pragma mark module descriptor
> +
> +vlc_module_begin ()
> +    set_shortname("audiounit_ios")
> +    set_description("AudioUnit output for iOS")
> +    set_capability("audio output", 101)
> +    set_category(CAT_AUDIO)
> +    set_subcategory(SUBCAT_AUDIO_AOUT)
> +    add_sw_gain()
> +    set_callbacks(Open, Close)
> +vlc_module_end ()
> -- 
> 2.20.1 (Apple Git-117)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel