[vlc-devel] [PATCH v2 2/2] aout/ios: Fix missing add_sw_gain macro

[Rémi Denis-Courmont]

Le jeudi 13 juin 2019, 12:21:32 EEST Marvin Scholz a écrit :
> Without that, the gain option would be missing, causing an assertion
> when calling var_InheritFloat in aout_SoftVolumeInit.
> ---
>  modules/audio_output/audiounit_ios.m | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules/audio_output/audiounit_ios.m
> b/modules/audio_output/audiounit_ios.m index b4f10bef2a..bea6af2091 100644
> --- a/modules/audio_output/audiounit_ios.m
> +++ b/modules/audio_output/audiounit_ios.m
> @@ -642,5 +642,6 @@ static int DeviceSelect(audio_output_t *p_aout, const
> char *psz_id) set_capability("audio output", 101)
>      set_category(CAT_AUDIO)
>      set_subcategory(SUBCAT_AUDIO_AOUT)
> +    add_sw_gain()
>      set_callbacks(Open, Close)
>  vlc_module_end ()

Honestly, VLC software gain generally sucks. And here it looks suspiciously 
like 592e854cab4f812f1645ef499a81c8d2adc155e6 was never tested and never used.

It might be better to remove SW gain then.

-- 
Rémi Denis-Courmont