[vlc-devel] [PATCH 1/2] d3d9: don't use the invalid picture flag

Steve Lhomme robux4 at ycbcr.xyz
Fri Jun 14 08:46:45 CEST 2019


OK with that one although it looks less consistent. One has to look 
around in the code why this test is used, while the has_pictures_invalid 
is self explanatory to use with SendEventPicturesInvalid().

On 2019-06-14 6:49, RĂ©mi Denis-Courmont wrote:
> This was meant to be written, not read, by the display.
> ---
>   modules/video_output/win32/direct3d9.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/video_output/win32/direct3d9.c b/modules/video_output/win32/direct3d9.c
> index e34b5416c2..da4f4a8e7c 100644
> --- a/modules/video_output/win32/direct3d9.c
> +++ b/modules/video_output/win32/direct3d9.c
> @@ -1282,7 +1282,7 @@ static void Prepare(vout_display_t *vd, picture_t *picture,
>       HRESULT hr = IDirect3DDevice9_TestCooperativeLevel(p_d3d9_dev->dev);
>       if (FAILED(hr)) {
>           if (hr == D3DERR_DEVICENOTRESET && !sys->reset_device) {
> -            if (vd->info.has_pictures_invalid)
> +            if (!is_d3d9_opaque(picture->fmt.i_chroma))
>                   vout_display_SendEventPicturesInvalid(vd);
>               sys->reset_device = true;
>               sys->lost_not_ready = false;
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list