[vlc-devel] [PATCH] Fix for crc_octets CRC24_POLY

[Rémi Denis-Courmont]

Hi,

This erratum is in held for update status, meaning it will be taken into the next version of the protocol, in the form of a new RFC (if ever).

Published RFC's don't change. They can only be superseded by new RFC's.

Le 17 juin 2019 09:27:57 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-06-15 13:04, Marco Bellaccini wrote:
>> I've fixed crc_octets CRC24_POLY value in update_crypto.c.
>> There is a typo in the RFC from which it was copied:
>> https://www.rfc-editor.org/errata/eid5491
>
>Hi,
>
>Are the errata official and applied ? Looking at the RFC 4880 directly 
>from the IETF I see no correction in the document:
>https://tools.ietf.org/html/rfc4880
>
>There is a link to the Errata though.
>
>> Cheers
>> 
>> Marco Bellaccini
>> 
>> 0001-Fixed-crc_octets-CRC24_POLY.patch
>> 
>>  From d68a8b2e10227ddbe40065aadc9660c91f81920c Mon Sep 17 00:00:00
>2001
>> From: Marco Bellaccini
><24960638+marcobellaccini at users.noreply.github.com>
>> Date: Sat, 15 Jun 2019 12:21:20 +0200
>> Subject: [PATCH] Fixed crc_octets CRC24_POLY
>> 
>> ---
>>   src/misc/update_crypto.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/src/misc/update_crypto.c b/src/misc/update_crypto.c
>> index d3d555fc60..c161a3928d 100644
>> --- a/src/misc/update_crypto.c
>> +++ b/src/misc/update_crypto.c
>> @@ -350,7 +350,7 @@ error:
>>    * Copyright (C) The Internet Society (1998).  All Rights Reserved.
>>    */
>>   #define CRC24_INIT 0xB704CEL
>> -#define CRC24_POLY 0x1864CFBL
>> +#define CRC24_POLY 0x864CFBL /* see RFC 4880 Errata ID 5491 */
>>   
>>   static long crc_octets( uint8_t *octets, size_t len )
>>   {
>> -- 
>> 2.20.1
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190617/001430f7/attachment.html>