[vlc-devel] [PATCH 3/5] configure: define socklen_t to int not unsigned int

Steve Lhomme robux4 at ycbcr.xyz
Mon Jun 17 13:23:33 CEST 2019


OK for me, although from what Remi said, an int might work in all cases.

On 2019-06-17 12:24, KO Myung-Hun wrote:
> Hi/2.
> 
> Steve Lhomme wrote:
>> On 2019-06-16 16:35, KO Myung-Hun wrote:
>>> OS/2 socket APIs use int not unsigned int in place of socklen_t. As
>>> a result, compilation is stopped at function call requiring socklen_t *
>>> because of type mismatch between int * and unsigned int *.
>>
>> the spec says that socklen_t should be an unsigned integer of at least
>> 32 bits. So for OS/2 you may need an int64. But if pointers are used
>> that's not an option. So the patch should conditionally define socklen_t
>> to what you want only for OS/2. The rest of the time it should be as it
>> is now.
> 
> Fixed. Thanks.
> 
> -- 
> KO Myung-Hun
> 
> Using Mozilla SeaMonkey 2.7.2
> Under OS/2 Warp 4 for Korean with FixPak #15
> In VirtualBox v6.0.8 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
> 
> Korean OS/2 User Community : http://www.os2.kr/
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list