[vlc-devel] [PATCH] picture: export: Allow source picture to be cropped

Hugo Beauzée-Luyssen hugo at beauzee.fr
Wed Jun 19 09:49:44 CEST 2019

On Wed, Jun 19, 2019, at 7:23 AM, Steve Lhomme wrote:
> LGTM. Although I'm not sure the case where crop is false is very useful. 
>   Not knowing the source aspect ratio it will produce odd pictures in 
> the general case. Maybe we can just modify the case when both values are 
> positive.

That's a valid point, the only other usage is the snapshot code, and I'm not sure we would ever want to distort the resulting image. Then again, this behavior is documented, so I'm a bit reluctant to remove this feature.

In any case I forgot to expose the crop parameter to the libvlc API, so I'll need to add an extra patch before pushing.

  Hugo Beauzée-Luyssen
  hugo at beauzee.fr

More information about the vlc-devel mailing list