[vlc-devel] [PATCH] contrib: do not add CFLAGS to EXTRA_CFLAGS

Steve Lhomme robux4 at ycbcr.xyz
Wed Jun 19 12:11:49 CEST 2019


LGTM

On 2019-06-19 11:29, Marvin Scholz wrote:
> This would cause the flags to be duplicated as later CFLAGS
> are set to $(CFLAGS) $(EXTRA_CFLAGS).
> ---
>   contrib/src/main.mak | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index 4aa9c2c3b8..cc347b794b 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -147,7 +147,6 @@ ifdef HAVE_NEON
>   AS=perl $(abspath $(VLC_TOOLS)/bin/gas-preprocessor.pl) $(CC)
>   CCAS=gas-preprocessor.pl $(CC) -c
>   endif
> -EXTRA_CFLAGS += $(CFLAGS)
>   endif
>   
>   LN_S = ln -s
> -- 
> 2.19.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list