[vlc-devel] [PATCH] player: fix crash caused by use after free

Victorien Le Couviour--Tuffet victorien.lecouviour.tuffet at gmail.com
Wed Jun 19 21:34:56 CEST 2019


---
 src/input/player.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/input/player.c b/src/input/player.c
index 54a39bed87..d53384c770 100644
--- a/src/input/player.c
+++ b/src/input/player.c
@@ -3426,7 +3426,8 @@ vlc_player_VoutOSDCallback(vlc_object_t *this, const char *var,
             newval.psz_string : var_GetString(vout, "deinterlace-mode");
         vouts_osd_Message(&vout, 1, _("Deinterlace %s (%s)"),
                           on == 1 ? _("On") : _("Off"), mode);
-        free(mode);
+        if (!varmode)
+            free(mode);
     }
 
     else if (strcmp(var, "sub-margin") == 0)
-- 
2.21.0



More information about the vlc-devel mailing list