[vlc-devel] [PATCH] access/decklink: Add missing vlc_decklink.h

[Marvin Scholz]

On 21 Jun 2019, at 12:52, Francois Cartegnie wrote:

> Le 21/06/2019 à 12:37, Marvin Scholz a écrit :
>> Without that one added, a dist tarball would lack the header
>> and the build of all decklink modules would fail.
>> ---
>>  modules/access/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/access/Makefile.am b/modules/access/Makefile.am
>> index 919ac4b408..1b85e8dd18 100644
>> --- a/modules/access/Makefile.am
>> +++ b/modules/access/Makefile.am
>> @@ -122,7 +122,7 @@ liblinsys_sdi_plugin_la_LDFLAGS = $(AM_LDFLAGS) 
>> -rpath '$(accessdir)'
>>  access_LTLIBRARIES += $(LTLIBlinsys_hdsdi) $(LTLIBlinsys_sdi)
>>  EXTRA_LTLIBRARIES += liblinsys_hdsdi_plugin.la 
>> liblinsys_sdi_plugin.la
>>
>> -libdecklink_plugin_la_SOURCES = access/decklink.cpp access/sdi.c 
>> access/sdi.h
>> +libdecklink_plugin_la_SOURCES = access/decklink.cpp access/sdi.c 
>> access/sdi.h access/vlc_decklink.h
>>  libdecklink_plugin_la_CXXFLAGS = $(AM_CXXFLAGS) $(CPPFLAGS_decklink)
>>  libdecklink_plugin_la_LIBADD = $(LIBS_decklink) $(LIBDL) -lpthread
>>  if HAVE_DECKLINK
>>
>
> If it's missing from the dist, it's missing somewhere else, not in 
> modules.

I am not sure what you mean. This fix works, I tested it.
The file (vlc_decklink.h) is in the access folder so it made
the most sense to add it to the makefile here.

>
> But I think that vlc_decklink.h was a bad idea.
> That should rather be a local fix header inside the modules directory.
> (where in that case the above change would be needed).
>

What do you mean by that? This is inside the modules directory.

> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel