[vlc-devel] [PATCH] libvlc/core: Use a revision.h in build dir instead of .c file

[Rémi Denis-Courmont]

Le vendredi 21 juin 2019, 12:18:01 EEST Marvin Scholz a écrit :
> I mainly need this change for meson and I do not want the
> code to diverge between the meson branch and our current
> buildsystem.

I utterly fail to see how this relates to Meson TBH.

(...)
> If the file is a .c file though, meson will compile + link
> the file into both libraries. The problem with that is that
> lib/core.c additionally includes the .c file, so now the
> library would end up with the symbol twice, one time from the
> linked revision.o, one time from the included revision.c,
> which will fail to link.

No it won't fail to link - unless you messed something else up.

It's perfectly fine to have the same extern symbol in an underlying library, 
indeed even if it is statically linked. What's not fine is having the same 
extern symbols in multiple objects of the *same* library/executable.

And that's really down to linker requirements, has nothing to do with the 
build system.

-- 
Rémi Denis-Courmont