[vlc-devel] [PATCH 5/6] sout: sdi: remove redundant decoder picture allocation

Steve Lhomme robux4 at ycbcr.xyz
Tue Jun 25 13:53:16 CEST 2019


The core can do it by default.
---
 modules/stream_out/sdi/SDIStream.cpp | 6 ------
 modules/stream_out/sdi/SDIStream.hpp | 1 -
 2 files changed, 7 deletions(-)

diff --git a/modules/stream_out/sdi/SDIStream.cpp b/modules/stream_out/sdi/SDIStream.cpp
index 5202bd331c..e656101bc0 100644
--- a/modules/stream_out/sdi/SDIStream.cpp
+++ b/modules/stream_out/sdi/SDIStream.cpp
@@ -293,7 +293,6 @@ void VideoDecodedStream::setCallbacks()
     static struct decoder_owner_callbacks dec_cbs;
     memset(&dec_cbs, 0, sizeof(dec_cbs));
     dec_cbs.video.format_update = VideoDecCallback_update_format;
-    dec_cbs.video.buffer_new = VideoDecCallback_new_buffer;
     dec_cbs.video.queue = VideoDecCallback_queue;
     dec_cbs.video.queue_cc = VideoDecCallback_queue_cc;
 
@@ -334,11 +333,6 @@ int VideoDecodedStream::VideoDecCallback_update_format(decoder_t *p_dec)
     return VLC_SUCCESS;
 }
 
-picture_t *VideoDecodedStream::VideoDecCallback_new_buffer(decoder_t *p_dec)
-{
-    return picture_NewFromFormat(&p_dec->fmt_out.video);
-}
-
 
 static picture_t *transcode_video_filter_buffer_new(filter_t *p_filter)
 {
diff --git a/modules/stream_out/sdi/SDIStream.hpp b/modules/stream_out/sdi/SDIStream.hpp
index 09ef279915..669de6dab1 100644
--- a/modules/stream_out/sdi/SDIStream.hpp
+++ b/modules/stream_out/sdi/SDIStream.hpp
@@ -135,7 +135,6 @@ namespace sdi_sout
             static void VideoDecCallback_queue_cc( decoder_t *, block_t *,
                                                    const decoder_cc_desc_t * );
             static int VideoDecCallback_update_format(decoder_t *);
-            static picture_t *VideoDecCallback_new_buffer(decoder_t *);
             filter_chain_t * VideoFilterCreate(const es_format_t *);
             void Output(picture_t *);
             void QueueCC(block_t *);
-- 
2.17.1



More information about the vlc-devel mailing list