[vlc-devel] [PATCH 1/2] input: Create: Invert b_preparsing check

Thomas Guillem thomas at gllm.fr
Wed Jun 26 17:12:46 CEST 2019


OK for the set.

On Wed, Jun 26, 2019, at 17:11, Hugo Beauzée-Luyssen wrote:
> Now that there is more than 2 possible modes (regular playback,
> preparsing, thumbnailing) it makes more sense to check for an explicit
> match.
> ---
>  src/input/input.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/input/input.c b/src/input/input.c
> index ab96f29afa..dc4c53602b 100644
> --- a/src/input/input.c
> +++ b/src/input/input.c
> @@ -350,7 +350,12 @@ static input_thread_t *Create( vlc_object_t *p_parent,
>  
>      /* setup the preparse depth of the item
>       * if we are preparsing, use the i_preparse_depth of the parent item */
> -    if( !priv->b_preparsing )
> +    if( priv->b_preparsing )
> +    {
> +        p_input->obj.logger = NULL;
> +        p_input->obj.no_interact = true;
> +    }
> +    else
>      {
>          char *psz_rec = var_InheritString( p_parent, "recursive" );
>  
> @@ -366,11 +371,6 @@ static input_thread_t *Create( vlc_object_t *p_parent,
>          } else
>              p_item->i_preparse_depth = -1;
>      }
> -    else
> -    {
> -        p_input->obj.logger = NULL;
> -        p_input->obj.no_interact = true;
> -    }
>  
>      /* Make sure the interaction option is honored */
>      if( !var_InheritBool( p_input, "interact" ) )
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list