[vlc-devel] [PATCH V2 3/4] modules: audio_filter: return vlc_block_discontinuity when needed

Rémi Denis-Courmont remi at remlab.net
Mon Mar 4 12:55:16 CET 2019


I agree with you (and seemingly Denis) that we should use a real writable block to carry flags. And zero-size block is then the logical way forward.

Unfortunately, as far as I am aware, we do not support zero-size blocks at the moment. Some code paths explicitly drop such blocks and presumably other just fail one way or other (e.g. divide by zero). So unless somebody volunteers to investigate and fix that, it's a no go.

Le 2 mars 2019 19:04:26 GMT+02:00, Francois Cartegnie <fcartegnie at gmail.com> a écrit :
>Le 01/03/2019 à 12:41, Thomas Guillem a écrit :
>I hardly see the need if we can return zero sized block with flags.
>Francois Cartegnie
>VideoLAN - VLC Developer
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:

Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190304/58767c2e/attachment.html>

More information about the vlc-devel mailing list