[vlc-devel] [PATCH 1/2] contrib: don't use an empty PKG_CONFIG_PATH at the end of the path

[Steve Lhomme]

On 3/6/2019 10:49 AM, Martin Storsjö wrote:
> On Wed, 6 Mar 2019, Steve Lhomme wrote:
>
>> pkg-config fails to find packages (on msys2) if the path is like
>> /some/path:/other/path:
>> ---
>> contrib/src/main.mak | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index d3caf2c8dc..8f9e723a71 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -215,7 +215,11 @@ PKG_CONFIG_PATH := /usr/share/pkgconfig
>> PKG_CONFIG_LIBDIR := /usr/$(HOST)/lib/pkgconfig
>> export PKG_CONFIG_LIBDIR
>> endif
>> +ifeq ($(findstring $(PKG_CONFIG_PATH),/),)
>> +PKG_CONFIG_PATH := $(PREFIX)/lib/pkgconfig
>> +else
>
> Why not just
>
> ifeq ($(PKG_CONFIG_PATH),)
>
> which (afaik) is the common way of checking for an empty/unset variable?

Indeed, it's much better. I wanted to do that but didn't know how to do 
it...