[vlc-devel] [PATCH 1/2] contrib: don't use an empty PKG_CONFIG_PATH at the end of the path

[Steve Lhomme]

On 3/6/2019 12:00 PM, Martin Storsjö wrote:
> On Wed, 6 Mar 2019, Rémi Denis-Courmont wrote:
>
>> Hi,
>>
>> I'd think the same effects can be done in a single line without an
>> if/else/endif.
>
> That would probably be this then:
>
> PKG_CONFIG_PATH := $(PREFIX)/lib/pkgconfig$(if 
> $(PKG_CONFIG_PATH),:)$(PKG_CONFIG_PATH)

Much better.

It turns out the msys2 pkg-config.exe can handle it just fine. But the 
one forcefully built in extra/tools doesn't. It is not build 
automatically anymore in 4.0 so this patch is not needed there. And I'm 
planning to update the tools system in 3.0 to avoid this.