[vlc-devel] [PATCH 03/18] clock: add vlc_clock

[Denis Charmet]

On 2019-03-07 17:51, Francois Cartegnie wrote:
> Le 07/03/2019 à 15:25, Thomas Guillem a écrit :
> 
>> + */
>> +vlc_tick_t vlc_clock_SetDelay(vlc_clock_t *clock, vlc_tick_t 
>> pts_delay);
>> +
>> +/**
>> + * Wait for a timestamp expressed in stream time
>> + */
>> +int vlc_clock_Wait(vlc_clock_t *clock, vlc_tick_t system_now, 
>> vlc_tick_t pts,
>> +                   double rate, vlc_tick_t max_duration);
>> +
> 
> I don't agree with the use of "pts" instead of "ts" or "timestamp".
> 
> This is confusing (even more when mixing usage with pts_delay which is
> related to the real pts thing) and we clearly don't want pts there.

Why is it confusing? You are waiting until the your streams playback 
reach this timestamp in stream time. The clock_Wait function is called 
with actual PTS of the frame to be displayed.

Regards,
-- 
Denis Charmet - TypX