[vlc-devel] [PATCH 0/8] asynchronous aout stream

[Thomas Guillem]

On Sun, Mar 10, 2019, at 18:27, Remi Denis-Courmont wrote:
> Le 2019-03-10 18:26, Thomas Guillem a écrit :
> > If the aout plugin is configured for a given
> > buffer size, we should not increase it by having an external queue.
> 
> Leaving aside pathological cases where the buffers are just too short, I 
> agree.
> 
> But...
> 
> > I
> > really prefer to wait from the core using a cond/mutex (so that we can
> > still control the aout).
> 
> That's also just moving the problem. You still need the audio output 
> plugin to call an underrun notifier to wake the condition variable or 
> the semaphore when buffer space is available.
> 
> So in the end, the only difference is where you queue the orveflowing 
> data, in the core or in the plugin. But it needs to be queued somewhere.

My very simple idea was just to wait for to_us(block->size) from the core, but we can add a signal call from the plugin. We can handle both since I don't know if every plugins will be clever... 

> 
> 
> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel