[vlc-devel] [PATCH 12/15] contrib: sdl: disable package not usable on Winstore builds

Steve Lhomme robux4 at ycbcr.xyz
Mon Mar 11 08:01:16 CET 2019


On 3/8/2019 8:31 PM, Jean-Baptiste Kempf wrote:
> I am suprised we cannot fix this, tbh.

I did not try to fix anything, just find out what have issues. Fixing 
will take many more days or work but will likely be needed at some point.

Also that only covers the contribs available in 3.0 and I did not try Qt.

>
> On Fri, 8 Mar 2019, at 16:21, Steve Lhomme wrote:
>> uses GetVersionEx and SetErrorMode (which are available since 16299)
>> uses GetDC, ReleaseDC, RealizePalette, CreateCompatibleBitmap, SetWindowLongPtr,
>> DefWindowProc, ClientToScreen which are not available
>> ---
>>   contrib/src/SDL_image/rules.mak | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/contrib/src/SDL_image/rules.mak
>> b/contrib/src/SDL_image/rules.mak
>> index c66911ac784..eb050dba5f3 100644
>> --- a/contrib/src/SDL_image/rules.mak
>> +++ b/contrib/src/SDL_image/rules.mak
>> @@ -20,8 +20,10 @@ SDL_image: SDL_image-$(SDL_IMAGE_VERSION).tar.gz
>> .sum-SDL_image
>>   	$(UPDATE_AUTOCONFIG)
>>   	$(MOVE)
>>   
>> -DEPS_SDL_image = jpeg $(DEPS_jpeg) tiff $(DEPS_tiff) \
>> -	sdl $(DEPS_sdl)
>> +DEPS_SDL_image = jpeg $(DEPS_jpeg) tiff $(DEPS_tiff)
>> +ifndef HAVE_WINSTORE
>> +DEPS_SDL_image += sdl $(DEPS_sdl)
>> +endif
>>   
>>   .SDL_image: SDL_image
>>   	cd $< && $(HOSTVARS) ./configure $(HOSTCONF) --enable-tif
>> --disable-sdltest --disable-png
>> -- 
>> 2.17.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list