[vlc-devel] [PATCH 5/6] alsa: remove the drain implementation

[Thomas Guillem]

On Tue, Mar 12, 2019, at 17:44, Rémi Denis-Courmont wrote:
> Le tiistaina 12. maaliskuuta 2019, 17.23.53 EET Thomas Guillem a écrit :
> > Since it's necessary blocking and synchronous (cf. next commits).
> 
> I completley disagree. Removing drain is not safe, and some drivers will 
> glitch with varying level of badness if not drained (or flushed) early enough 
> before the underrun.
> 
> This is not optional. Deal with it.

OK. FYI: alsa drain is always blocking, even when snd_pcm is opened with the SND_PCM_NONBLOCK flag.

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel