[vlc-devel] [PATCH 3/6] aout: use a seperate drain callback

[Thomas Guillem]

On Tue, Mar 12, 2019, at 18:05, Thomas Guillem wrote:
> 
> On Tue, Mar 12, 2019, at 17:46, Rémi Denis-Courmont wrote:
> > Le tiistaina 12. maaliskuuta 2019, 17.23.51 EET Thomas Guillem a écrit :
> > > This callback is not mandatory. If it is NULL, the core will wait for the
> > > delay returned by time_get(). This was already the case for most aout
> > > plugins: PulseAudio, coreaudio, Android, DirectSound, Wasapi, and Jack.
> > > 
> > > Note: The drain implementation of PulseAudio was removed since
> > > pa_stream_drain() never worked for our case.
> > 
> > Excuse me? Waiting for completition did not work at some point, but that does 
> > not mean that you can altogether remove the call.
> 
> OK, I'll try to add it back. But from my last tries, there were no way 
> to fetch the drain state.

As a workaround  for the drain state not being notified, I can call pa_drain and add a timer corresponding to the delay.

> 
> > 
> > Also nit, typo.
> > 
> > -- 
> > 雷米‧德尼-库尔蒙
> > http://www.remlab.net/
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel