[vlc-devel] [PATCH] Fixes #19388: Qt: makes network URL comboBox case sensitive

sagar kohli kohli.sagar2 at gmail.com
Wed Mar 13 06:17:43 CET 2019


Hi, can anyone review this patch. It works perfectly fine and closes #19388.

Regards
sagar-kohli

On Sat 9 Mar, 2019, 1:36 PM Sagar Kohli, <kohli.sagar2 at gmail.com> wrote:

> Open network stream's URL box was case insensitive. QComboBox is by
> default case insensitive when editable is enabled, by making its completer
> case sensitive resolves the problem.
> ---
>  modules/gui/qt/components/open_panels.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/modules/gui/qt/components/open_panels.cpp
> b/modules/gui/qt/components/open_panels.cpp
> index 64b79ecdb6..c75ccecc8e 100644
> --- a/modules/gui/qt/components/open_panels.cpp
> +++ b/modules/gui/qt/components/open_panels.cpp
> @@ -679,6 +679,9 @@ NetOpenPanel::NetOpenPanel( QWidget *_parent,
> intf_thread_t *_p_intf ) :
>
>      /* Use a simple validator for URLs */
>      ui.urlComboBox->setValidator( new UrlValidator( this ) );
> +
> +    /* QComboBox is by default case insensitive when editable, making it
> case sensitive */
> +    ui.urlComboBox->completer()->setCaseSensitivity( Qt::CaseSensitive );
>      ui.urlComboBox->setFocus();
>  }
>
> --
> 2.17.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190313/9cf11ca7/attachment.html>


More information about the vlc-devel mailing list