[vlc-devel] [vlc-commits] macosx: don't import the legacy playlist globally

[Felix Paul Kühne]

Hi David,

Thanks a lot for your detailed review of my commits.

> On 11. Mar 2019, at 21:43, David Fuhrmann <david.fuhrmann at gmail.com> wrote:
> 
> 
>> Am 11.03.2019 um 01:09 schrieb Felix Paul Kühne <git at videolan.org>:
>> 
>> diff --git a/modules/gui/macosx/main/VLCMain+OldPrefs.m b/modules/gui/macosx/main/VLCMain+OldPrefs.m
>> index 25a17cde0d..9066310d13 100644
>> --- a/modules/gui/macosx/main/VLCMain+OldPrefs.m
>> +++ b/modules/gui/macosx/main/VLCMain+OldPrefs.m
>> @@ -94,18 +94,10 @@ static const int kCurrentPreferencesVersion = 4;
>>        // In VLC 2.2.x, config for filters was fully controlled by audio and video effects panel.
>>        // In VLC 3.0, this is no longer the case and VLCs config is not touched anymore. Therefore,
>>        // disable filter in VLCs config in this transition.
>> -        playlist_t *p_playlist = pl_Get(getIntf());
>> -        var_SetString(p_playlist, "audio-filter", "");
>> -        var_SetString(p_playlist, "video-filter", "“);
> 
> Hi Felix,
> 
> Why do you change this method, can you please explain?
> I do not see why you can remove this currently, seeing that the Audio and video effects panels still use those strings.

The playlist is gone and so are those variables (for now). They will be reintroduced on the libvlc level by a future patch by Thomas. This should have been documented in a  separate commit - you are definitely right.

Best regards,

Felix