[vlc-devel] [PATCH 1/2] contrib: move the pkconfig path in the meson crossfile

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Mar 18 16:29:44 CET 2019


On Mon, Mar 18, 2019, at 3:00 PM, Steve Lhomme wrote:
> On 3/18/2019 2:08 PM, Hugo Beauzée-Luyssen wrote:
> > On Mon, Mar 18, 2019, at 1:51 PM, Steve Lhomme wrote:
> >> ---
> >>   contrib/src/main.mak | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> >> index 1623d846e5..416b4c4b22 100644
> >> --- a/contrib/src/main.mak
> >> +++ b/contrib/src/main.mak
> >> @@ -578,8 +578,8 @@ crossfile.meson:
> >>   	echo "cpp = '$(CXX)'" >> $@
> >>   	echo "ar = '$(AR)'" >> $@
> >>   	echo "strip = '$(STRIP)'" >> $@
> >> -	echo "pkgconfig = '$(PKG_CONFIG)'" >> $@
> >>   	echo "windres = '$(WINDRES)'" >> $@
> >> +	echo "pkgconfig = '$(PKG_CONFIG)'" >> $@
> >>   	echo "[properties]" >> $@
> >>   	echo "needs_exe_wrapper = true" >> $@
> >>   ifdef HAVE_CROSS_COMPILE
> > Any specific reason?
> 
> For the next patch. So that pkgconfig is not set twice depending on 
> which side of the if it is.

Don't pkg-config also need an absolute path? It might be used through meson as well no?

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list