[vlc-devel] [PATCH v2 6/7] aout: make the drain implementation asynchronous

[Rémi Denis-Courmont]

Le lundi 18 mars 2019, 10:18:34 EET Thomas Guillem a écrit :
> On Sat, Mar 16, 2019, at 03:31, Rémi Denis-Courmont wrote:
> > Le mercredi 13 mars 2019, 10:55:54 EET Thomas Guillem a écrit :
> > > Yes, only the waveout plugin can do an asynchronous drain (for now).
> > 
> > You wrote, on the very same topic, that the interface has to handle all
> > backends. Realistlcally, drain will be blocking for the foreseeable
> > future, at the very least because of ALSA. Deal with it.
> > 
> > Besides, there are no explanations what the point of this change is.
> > Asynchronous drain is not an end of its own, and I cannot say that I see
> > the use case (unlike asynchronous play).
> 
> Mostly to simplify lock handling,

If anything, it's going to make it more complicated, as you would release the 
lock in the middle of an (asynchronous) operation. That's not something we 
currently care about.

> But I still need to separate drain from flush and have the default loozy
> drain emulation for most modules.

Sure. I already agreed to the first parts of the patch series, did I not?

-- 
Rémi Denis-Courmont