[vlc-devel] [vlc-commits] configure: use WINSTORECOMPAT when building for Windows Store

Rémi Denis-Courmont remi at remlab.net
Tue Mar 19 16:29:54 CET 2019


Le mardi 19 mars 2019, 17:12:04 EET Steve Lhomme a écrit :
> On 3/19/2019 3:01 PM, Rémi Denis-Courmont wrote:
> > Le mardi 19 mars 2019, 12:50:50 EET Steve Lhomme a écrit :
> >> vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Wed Mar 13
> >> 15:51:28 2019 +0100| [277b45efff01dcccd42f1e4943aa09297f99650e] |
> >> committer: Steve Lhomme
> >> 
> >> configure: use WINSTORECOMPAT when building for Windows Store
> >> 
> >> We may use some forbidden APIs that are actually usable via
> >> WindowsStoreCompat
> > 
> > This is wrong. Please revert.
> 
> It's not *wrong*. That's not the way you would do it. But IMO it's safer
> that way for reasons already given.

It is wrong because that's not the way our chosen (autoconf in this case) 
build system does it, and inconsistent with the rest of the code base.

But obviously your niche Windows platform is so much important than all others 
(incl. desktop Windows) that it deserves its own hacks for the alleged sake of 
"safety".

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list