[vlc-devel] [vlc-commits] configure: use WINSTORECOMPAT when building for Windows Store

[Steve Lhomme]

On 3/19/2019 5:09 PM, Rémi Denis-Courmont wrote:
> It is safer to put things in config.h because that's tracked by 
> dependency propagation, can have order adjusted easily and does not 
> extend the command line in unreasonable.
>
> + Arguments already made.
>
> If you don't revert this, I'll have to raise it to the ctte.

I won't revert this unless there are good reasons.

>
> Le 20 mars 2019 00:02:36 GMT+08:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
>
>     On 3/19/2019 4:29 PM, Rémi Denis-Courmont wrote:
>
>         Le mardi 19 mars 2019, 17:12:04 EET Steve Lhomme a écrit :
>
>             On 3/19/2019 3:01 PM, Rémi Denis-Courmont wrote:
>
>                 Le mardi 19 mars 2019, 12:50:50 EET Steve Lhomme a
>                 écrit :
>
>                     vlc | branch: master | Steve Lhomme
>                     <robux4 at ycbcr.xyz> | Wed Mar 13 15:51:28 2019
>                     +0100| [277b45efff01dcccd42f1e4943aa09297f99650e]
>                     | committer: Steve Lhomme configure: use
>                     WINSTORECOMPAT when building for Windows Store We
>                     may use some forbidden APIs that are actually
>                     usable via WindowsStoreCompat 
>
>                 This is wrong. Please revert. 
>
>             It's not *wrong*. That's not the way you would do it. But
>             IMO it's safer that way for reasons already given. 
>
>         It is wrong because that's not the way our chosen (autoconf in
>         this case) build system does it, and inconsistent with the
>         rest of the code base. 
>
>
>     I see plenty of -D in configure.ac (not including the ones for some
>     modules).
>
>     AH_TOP and AH_BOTTOM have been giving issues when building for Windows
>     already and many have been removed because of that. There's no reason to
>     go back that way.
>
>     And of course the forced linking cannot be added through AH_*
>
>     As for _GNU_SOURCE you mentioned in your review, it's coming from
>     AC_USE_SYSTEM_EXTENSIONS and it's using AC_DEFINE and AC_VERBATIM. But
>     there's no guarantee that config.h is included in every file and
>     included before any windows header. So it's safer to define it via the
>     compiler.
>
>     >
>
>         But obviously your niche Windows platform is so much important
>         than all others (incl. desktop Windows) that it deserves its
>         own hacks for the alleged sake of "safety". -- Rémi Denis-Courmont
>         ------------------------------------------------------------------------
>         vlc-devel mailing list To unsubscribe or modify your
>         subscription options:
>         https://mailman.videolan.org/listinfo/vlc-devel 
>
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
>
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté.
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel