[vlc-devel] [vlc-commits] configure: use WINSTORECOMPAT when building for Windows Store

Steve Lhomme robux4 at ycbcr.xyz
Wed Mar 20 05:43:12 CET 2019

The opposite of "good" in this case is not "bad", it's "not good enough" to require a revert.

If you want one more reason this macro is better, it checks that that it's not already set before, not overriding the environment. I expect the WINSTORECOMPAT define to evolve in the future to tell the compatibility version. This will not break but it would with hardcoded value.

That's also why _WINNT_VER should use this as well rather than AH_ macros that prevents forcing a higher compatibility.

> On 20 Mar 2019, at 03:53, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le mardi 19 mars 2019, 18:44:56 EET Steve Lhomme a écrit :
>> On 3/19/2019 5:09 PM, Rémi Denis-Courmont wrote:
>>> It is safer to put things in config.h because that's tracked by
>>> dependency propagation, can have order adjusted easily and does not
>>> extend the command line in unreasonable.
>>> + Arguments already made.
>>> If you don't revert this, I'll have to raise it to the ctte.
>> I won't revert this unless there are good reasons.
> Implying that I gave bad reasons? Tha's offensive and provocative.
> If that's the attitude, then I won't be providing explanations in code review 
> to you and your colleagues. This is clearly a waste of my FREE time.
> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list