[vlc-devel] [PATCH 1/3] access: rist: add missing cleanup code for sockets and flow buffer

[Sergio M. Ammirata]

Understood. I will post a new set of the original 4 patches merged with these last 3.

 

From: vlc-devel [mailto:vlc-devel-bounces at videolan.org] On Behalf Of Thomas Guillem
Sent: Tuesday, March 19, 2019 3:49 AM
To: Mailing list for VLC media player developers
Subject: Re: [vlc-devel] [PATCH 1/3] access: rist: add missing cleanup code for sockets and flow buffer

 

Hello Sergio,

 

Generally, you should not send patches that fix a patch. Indeed, we push commits that fix old commits only when there are already merged. If they are not merged, there is no need to pollute the git history with lot of patches when there could be one.

 

You should squash them locally within your commits and send again the original fixed patches.

 

On Mon, Mar 18, 2019, at 16:54, Sergio M. Ammirata wrote:

 

 

_______________________________________________

vlc-devel mailing list

To unsubscribe or modify your subscription options:

https://mailman.videolan.org/listinfo/vlc-devel

 

Attachments:

*	0001-access-rist-add-missing-cleanup-code-for-sockets-and.patch

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190319/fb5630a1/attachment-0001.html>