[vlc-devel] [PATCH] Fix double free in stream deletion

[Steve Lhomme]

On 3/20/2019 3:51 PM, Thomas Guillem wrote:
> I think you should set p_module and description to NULL for spu and 
> video like it's done for audio.

That's what the previous patch was doing. But IMO it's not correct. 
Although I don't understand what Francois is referring to.

It could be the decoder must be released before the rest of the 
*_clean() function is done, but I don't see anything in there that looks 
dubious.

>
> On Wed, Mar 20, 2019, at 15:46, Awais Chishti wrote:
>> Hi,
>> Can you please specify whether you're saying that the crash is 
>> impossible or that the workaround can not be implemented
>> I'm new to the code so it isn't explanatory from your reason
>>
>> On Wed, Mar 20, 2019 at 7:32 PM Francois Cartegnie 
>> <fcartegnie at gmail.com <mailto:fcartegnie at gmail.com>> wrote:
>>
>>     Le 20/03/2019 à 18:08, chishtiawais511 at gmail.com
>>     <mailto:chishtiawais511 at gmail.com> a écrit :
>>     > From: Awais Chishti <chishtiawais511 at gmail.com
>>     <mailto:chishtiawais511 at gmail.com>>
>>     >
>>     > Decoder cleaning is being done with module_unneed() once in
>>     transcode.c:697 and sometimes in the preceeding switch statement
>>     causing VLC to crash. Either avoid cleaning the decoder in
>>     DeleteSoutStreamID() or in the transcode_*() functions. The patch
>>     does the latter as suggested earlier.
>>     > ---
>>
>>
>>     AFAIR that's not possible as the decoder probing must
>>     copy the resulting format while the decoder is not touching it.
>>
>>
>>     -- 
>>     Francois Cartegnie
>>     VideoLAN - VLC Developer
>>     _______________________________________________
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel