[vlc-devel] [PATCH 03/10] aout: aout_DecDrain: drain at the end

Thomas Guillem thomas at gllm.fr
Wed Mar 20 16:53:34 CET 2019


On Wed, Mar 20, 2019, at 14:09, Rémi Denis-Courmont wrote:
> Err? Is it safe to reset the clock before draining? Seems fishy even if it might accidentally work.

It should be safe but I don't need this patch finally. I can setup gapless in place of aout_Drain()

> 
> Le 20 mars 2019 00:45:18 GMT+08:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>>  src/audio_output/dec.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/src/audio_output/dec.c b/src/audio_output/dec.c
>> index d14218600b..ae686f2dc2 100644
>> --- a/src/audio_output/dec.c
>> +++ b/src/audio_output/dec.c
>> @@ -554,11 +554,11 @@ void aout_DecDrain(audio_output_t *aout)
>>      if (block)
>>          aout->play(aout, block, vlc_tick_now());
>>  
>> -    aout_Drain(aout);
>> -
>>      vlc_clock_Reset(owner->sync.clock);
>>      aout_FiltersResetClock(owner->filters);
>>  
>>      owner->sync.discontinuity = true;
>>      owner->original_pts = VLC_TICK_INVALID;
>> +
>> +    aout_Drain(aout);
>>  }
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190320/7013785e/attachment.html>


More information about the vlc-devel mailing list