[vlc-devel] [PATCH v2 3/7] aout: add gapless support

[Thomas Guillem]

On Thu, Mar 21, 2019, at 15:30, Rémi Denis-Courmont wrote:
> Le jeudi 21 mars 2019, 15:34:04 EET Thomas Guillem a écrit :
> > On Thu, Mar 21, 2019, at 14:29, Rémi Denis-Courmont wrote:
> > > No. You are making unwarranted assumptions, and not just about no audio
> > > ES. I cannot agree.
> > That is why I will start the next input, and pause it before it request new
> > ouputs (vout/aout/spu/aout). Then, if there is an audio track, I'll compare
> > the format to the current one and enable gapless accordingly.
> > 
> > Why unwarranted assumptions am I making in that case ?
> 
> For the umpteenth time.
> 
> You're assuming that those informations will come early enough to drain and 
> stop, if stitching the streams turns out not possible. Early enough is at 
> DecDrain() time. Later than that is unwarranted assumption.

That is what I'm saying, no ? This set is not correct. I'll work on creating an input in parallel in order to have these informations before the drain. For very small inputs, these information won't come early enough. In that case we won't enable gapless mode.

> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel