[vlc-devel] [PATCH] Fix double free in stream deletion

Francois Cartegnie fcartegnie at gmail.com
Thu Mar 21 16:08:42 CET 2019

Le 21/03/2019 à 16:20, Steve Lhomme a écrit :
> I'd like Francois to clarify what he meant.
> On 3/21/2019 8:32 AM, Awais Chishti wrote:
>> So, what do we do to fix it?
>> On Wed, Mar 20, 2019 at 7:58 PM Steve Lhomme <robux4 at ycbcr.xyz
>> <mailto:robux4 at ycbcr.xyz>> wrote:
>>     On 3/20/2019 3:51 PM, Thomas Guillem wrote:
>>     > I think you should set p_module and description to NULL for spu and
>>     > video like it's done for audio.
>>     That's what the previous patch was doing. But IMO it's not correct.
>>     Although I don't understand what Francois is referring to.
>>     It could be the decoder must be released before the rest of the
>>     *_clean() function is done, but I don't see anything in there that
>>     looks
>>     dubious.

We copy fmt_in or fmt_out for info we need late, after the decoder chain
is created in transcode test steps, after start/stopping the decoder/chain.

This needs to be compared to behavior before transcode split/refactoring

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list