[vlc-devel] [PATCH] Disable all unnecessary warnings of implicit fallthrough
Thomas Guillem
thomas at gllm.fr
Tue Mar 26 09:45:29 CET 2019
The commit log need to be more explicit.
You should explain which compiler or compiler version can't handle /* fallthrough */ correctly.
On Fri, Mar 22, 2019, at 09:36, chishtiawais511 at gmail.com wrote:
> From: Awais Chishti <chishtiawais511 at gmail.com>
>
> ---
> modules/access/linsys/linsys_sdi.c | 12 ++++++------
> modules/codec/aom.c | 4 ++--
> modules/demux/mkv/matroska_segment.cpp | 10 +++++-----
> modules/demux/mp4/essetup.c | 2 +-
> modules/demux/mp4/heif.c | 2 +-
> modules/demux/mpeg/ps.c | 2 +-
> modules/demux/mpeg/ts_psi.c | 4 ++--
> modules/demux/ogg.c | 6 +++---
> modules/demux/ogg_granule.c | 2 +-
> modules/gui/qt/components/controller.cpp | 2 +-
> modules/mux/mp4/libmp4mux.c | 2 +-
> modules/packetizer/a52.c | 8 ++++----
> modules/packetizer/dts.c | 6 +++---
> modules/packetizer/flac.c | 6 +++---
> modules/packetizer/h264_nal.c | 2 +-
> modules/packetizer/mlp.c | 8 ++++----
> modules/packetizer/mpeg4audio.c | 6 +++---
> modules/packetizer/mpegaudio.c | 8 ++++----
> modules/packetizer/packetizer_helper.h | 2 +-
> modules/stream_out/chromecast/chromecast_ctrl.cpp | 6 +++---
> modules/video_filter/ripple.c | 2 +-
> modules/video_filter/transform.c | 2 +-
> modules/video_filter/wave.c | 2 +-
> modules/video_output/win32/d3d11_quad.c | 2 +-
> src/preparser/preparser.c | 2 +-
> 25 files changed, 55 insertions(+), 55 deletions(-)
>
> diff --git a/modules/access/linsys/linsys_sdi.c
> b/modules/access/linsys/linsys_sdi.c
> index 8ce44d46d0..12087ae81d 100644
> --- a/modules/access/linsys/linsys_sdi.c
> +++ b/modules/access/linsys/linsys_sdi.c
> @@ -1430,7 +1430,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> break;
> p_sys->i_state = STATE_STARTSYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_STARTSYNC:
> p_parser = FindReferenceCode( FIELD_1_VBLANK_EAV, p_parser,
> p_end );
> @@ -1439,7 +1439,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> p_sys->i_anc_size = 0;
> p_sys->i_state = STATE_ANCSYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_ANCSYNC:
> p_parser = CountReference( &p_sys->i_anc_size,
> @@ -1449,7 +1449,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> p_sys->i_active_size = 0;
> p_sys->i_state = STATE_LINESYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_LINESYNC:
> p_parser = CountReference( &p_sys->i_active_size,
> @@ -1459,7 +1459,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> p_sys->i_picture_size = p_sys->i_anc_size +
> p_sys->i_active_size;
> p_sys->i_state = STATE_ACTIVESYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_ACTIVESYNC:
> p_parser = CountReference( &p_sys->i_picture_size,
> @@ -1470,7 +1470,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> / (p_sys->i_anc_size +
> p_sys->i_active_size);
> p_sys->i_state = STATE_VBLANKSYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_VBLANKSYNC:
> p_parser = CountReference( &p_sys->i_picture_size,
> @@ -1479,7 +1479,7 @@ static int HandleSDBuffer( demux_t *p_demux,
> uint8_t *p_buffer,
> break;
> p_sys->i_state = STATE_PICSYNC;
> p_sys->i_last_state_change = vlc_tick_now();
> - /* fallthrough */
> + /* fall through */
>
> case STATE_PICSYNC:
> p_parser = CountReference( &p_sys->i_picture_size,
> diff --git a/modules/codec/aom.c b/modules/codec/aom.c
> index e4f26c3916..1c63e9238c 100644
> --- a/modules/codec/aom.c
> +++ b/modules/codec/aom.c
> @@ -467,10 +467,10 @@ static int OpenEncoder(vlc_object_t *p_this)
>
> case 1:
> /* High Profile: 8 and 10-bit 4:4:4 */
> - /* fallthrough */
> + /* fall through */
> case 2:
> /* Professional Profile: 8, 10 and 12-bit for 4:2:2,
> otherwise 12-bit. */
> - /* fallthrough */
> + /* fall through */
> default:
> msg_Err( p_enc, "Unsupported profile %d", i_profile );
> free( p_sys );
> diff --git a/modules/demux/mkv/matroska_segment.cpp
> b/modules/demux/mkv/matroska_segment.cpp
> index 9aed37b59a..f1c2ebd8e0 100644
> --- a/modules/demux/mkv/matroska_segment.cpp
> +++ b/modules/demux/mkv/matroska_segment.cpp
> @@ -982,11 +982,11 @@ void matroska_segment_c::ComputeTrackPriority()
> switch( it->second->fmt.i_cat )
> {
> case VIDEO_ES: ++track_score;
> - /* fallthrough */
> + /* fall through */
> case AUDIO_ES: ++track_score;
> - /* fallthrough */
> + /* fall through */
> case SPU_ES: ++track_score;
> - /* fallthrough */
> + /* fall through */
> default:
> if( score < track_score )
> {
> @@ -1398,7 +1398,7 @@ int matroska_segment_c::BlockGet( KaxBlock * &
> pp_block, KaxSimpleBlock * & pp_s
> switch( i_level )
> {
> case 2:
> - /* fallthrough */
> + /* fall through */
> case 3:
> if( unlikely( !el->ValidateSize() || (
> el->IsFiniteSize() && el->GetSize() >= SIZE_MAX ) ) )
> {
> @@ -1414,7 +1414,7 @@ int matroska_segment_c::BlockGet( KaxBlock * &
> pp_block, KaxSimpleBlock * & pp_s
>
> break;
> }
> - /* fallthrough */
> + /* fall through */
> case 1:
> {
> EbmlTypeDispatcher const * dispatcher =
> dispatchers[i_level - 1];
> diff --git a/modules/demux/mp4/essetup.c b/modules/demux/mp4/essetup.c
> index 4ec1bbc85b..733841b82d 100644
> --- a/modules/demux/mp4/essetup.c
> +++ b/modules/demux/mp4/essetup.c
> @@ -787,7 +787,7 @@ int SetupVideoES( demux_t *p_demux, mp4_track_t
> *p_track, MP4_Box_t *p_sample )
>
> case ATOM_WMV3:
> p_track->p_asf = MP4_BoxGet( p_sample, "ASF " );
> - /* fallthrough */
> + /* fall through */
> case ATOM_H264:
> case VLC_FOURCC('W','V','C','1'):
> {
> diff --git a/modules/demux/mp4/heif.c b/modules/demux/mp4/heif.c
> index 18ad595e72..dd4a9cdbac 100644
> --- a/modules/demux/mp4/heif.c
> +++ b/modules/demux/mp4/heif.c
> @@ -513,7 +513,7 @@ static int ReadDerivationData( demux_t *p_demux,
> vlc_fourcc_t type,
> case VLC_FOURCC('g','r','i','d'):
> i_ret = ReadDerivationData_Grid( p_data->p_buffer,
> p_data->i_buffer, d );
> - /* fallthrough */
> + /* fall through */
> default:
> break;
> }
> diff --git a/modules/demux/mpeg/ps.c b/modules/demux/mpeg/ps.c
> index 01e7ff087b..09459078f9 100644
> --- a/modules/demux/mpeg/ps.c
> +++ b/modules/demux/mpeg/ps.c
> @@ -510,7 +510,7 @@ static int Demux( demux_t *p_demux )
> block_Release( p_pkt );
> break;
> }
> - /* fallthrough */
> + /* fall through */
> case PS_STREAM_ID_PRIVATE_STREAM1:
> case PS_STREAM_ID_EXTENDED:
> {
> diff --git a/modules/demux/mpeg/ts_psi.c b/modules/demux/mpeg/ts_psi.c
> index e9fb6659d1..7f9eef515f 100644
> --- a/modules/demux/mpeg/ts_psi.c
> +++ b/modules/demux/mpeg/ts_psi.c
> @@ -337,7 +337,7 @@ static void ParsePMTPrivateRegistrations( demux_t
> *p_demux, const dvbpsi_descrip
> break;
> }
> }
> - /* fallthrough */
> + /* fall through */
> default:
> msg_Dbg( p_demux, PMT_DESC_PREFIX "Unknown Private
> (0x%x)", p_dr->i_tag );
> break;
> @@ -1665,7 +1665,7 @@ static void FillPESFromDvbpsiES( demux_t *p_demux,
> /* All other private or reserved types */
> case 0x13: /* SL in sections */
> p_pes->transport = TS_TRANSPORT_SECTIONS;
> - /* fallthrough */
> + /* fall through */
> case 0x0f:
> case 0x10:
> case 0x11:
> diff --git a/modules/demux/ogg.c b/modules/demux/ogg.c
> index b57bf968ca..2c6e915066 100644
> --- a/modules/demux/ogg.c
> +++ b/modules/demux/ogg.c
> @@ -1234,7 +1234,7 @@ static void Ogg_DecodePacket( demux_t *p_demux,
> #ifdef HAVE_LIBVORBIS
> Ogg_DecodeVorbisHeader( p_stream, p_oggpacket,
> p_stream->i_packets_backup );
> #endif
> - /* fallthrough */
> + /* fall through */
> case VLC_CODEC_THEORA:
> if( p_stream->i_packets_backup == 3 )
> p_stream->b_force_backup = false;
> @@ -2741,7 +2741,7 @@ static void Ogg_DecodeVorbisHeader(
> logical_stream_t *p_stream,
> }
> vorbis_info_init( p_stream->special.vorbis.p_info );
> vorbis_comment_init( p_stream->special.vorbis.p_comment );
> - /* fallthrough */
> + /* fall through */
>
> case VORBIS_HEADER_COMMENT:
> case VORBIS_HEADER_SETUP:
> @@ -2752,7 +2752,7 @@ static void Ogg_DecodeVorbisHeader(
> logical_stream_t *p_stream,
> break;
>
> p_stream->special.vorbis.i_headers_flags |=
> VORBIS_HEADER_TO_FLAG(i_number);
> - /* fallthrough */
> + /* fall through */
>
> default:
> break;
> diff --git a/modules/demux/ogg_granule.c b/modules/demux/ogg_granule.c
> index 87b05d5f3e..7e2e9c8dd6 100644
> --- a/modules/demux/ogg_granule.c
> +++ b/modules/demux/ogg_granule.c
> @@ -102,7 +102,7 @@ static int64_t Ogg_GranuleToSample( const
> logical_stream_t *p_stream, int64_t i_
> case VLC_CODEC_THEORA:
> if( p_stream->i_first_frame_index == 0 &&
> !p_stream->b_oggds )
> i_granule++;
> - /* fallthrough */
> + /* fall through */
> case VLC_CODEC_DAALA:
> case VLC_CODEC_KATE:
> {
> diff --git a/modules/gui/qt/components/controller.cpp
> b/modules/gui/qt/components/controller.cpp
> index 7a624234f5..78562a6fdb 100644
> --- a/modules/gui/qt/components/controller.cpp
> +++ b/modules/gui/qt/components/controller.cpp
> @@ -375,7 +375,7 @@ QWidget *AbstractController::createWidget(
> buttonType_e button, int options )
> break;
> case VOLUME_SPECIAL:
> b_special = true;
> - /* fallthrough */
> + /* fall through */
> case VOLUME:
> {
> SoundWidget *snd = new SoundWidget( this, p_intf, b_shiny,
> b_special );
> diff --git a/modules/mux/mp4/libmp4mux.c b/modules/mux/mp4/libmp4mux.c
> index f99a346336..7d513f1bf2 100644
> --- a/modules/mux/mp4/libmp4mux.c
> +++ b/modules/mux/mp4/libmp4mux.c
> @@ -574,7 +574,7 @@ static bo_t *GetESDS(mp4mux_trackinfo_t *p_track)
> i_object_profile_indication = 0x6a; /* Visual ISO/IEC
> 11172-2 */
> break;
> }
> - /* fallthrough */
> + /* fall through */
> case VLC_CODEC_MP2V:
> /* MPEG-I=0x6b, MPEG-II = 0x60 -> 0x65 */
> i_object_profile_indication = 0x61; /* Visual 13818-2 Main
> Profile */
> diff --git a/modules/packetizer/a52.c b/modules/packetizer/a52.c
> index 91afafcf54..b1b3cf1d28 100644
> --- a/modules/packetizer/a52.c
> +++ b/modules/packetizer/a52.c
> @@ -185,11 +185,11 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
> /* Need more data */
> return NULL;
> }
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> p_sys->i_state = STATE_HEADER;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_HEADER:
> /* Get A/52 frame header (VLC_A52_HEADER_SIZE bytes) */
> @@ -222,7 +222,7 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
>
> p_sys->i_input_size = p_sys->frame.i_size;
> p_sys->i_state = STATE_NEXT_SYNC;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> /* Check if next expected frame contains the sync word */
> @@ -272,7 +272,7 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
> return NULL;
> }
> p_sys->i_state = STATE_SEND_DATA;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SEND_DATA:
> if( !(p_out_buffer = GetOutBuffer( p_dec )) )
> diff --git a/modules/packetizer/dts.c b/modules/packetizer/dts.c
> index 0500009d57..aa818ba58e 100644
> --- a/modules/packetizer/dts.c
> +++ b/modules/packetizer/dts.c
> @@ -182,7 +182,7 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
> /* Need more data */
> return NULL;
> }
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> /* New frame, set the Presentation Time Stamp */
> @@ -193,7 +193,7 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
> date_Set( &p_sys->end_date, p_sys->i_pts );
> }
> p_sys->i_state = STATE_HEADER;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_HEADER:
> /* Get DTS frame header (VLC_DTS_HEADER_SIZE bytes) */
> @@ -351,7 +351,7 @@ static block_t *PacketizeBlock( decoder_t *p_dec,
> block_t **pp_block )
> return NULL;
> }
> p_sys->i_state = STATE_SEND_DATA;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SEND_DATA:
> if( !(p_out_buffer = GetOutBuffer( p_dec )) )
> diff --git a/modules/packetizer/flac.c b/modules/packetizer/flac.c
> index 244e0302cb..1bb8feedf6 100644
> --- a/modules/packetizer/flac.c
> +++ b/modules/packetizer/flac.c
> @@ -351,14 +351,14 @@ static block_t *Packetize(decoder_t *p_dec,
> block_t **pp_block)
>
> if( p_sys->i_state != STATE_SYNC )
> return NULL; /* Need more data */
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> /* Sync state is unverified until we have read frame header
> and checked CRC
> Once validated, we'll send data from NEXT_SYNC state where
> we'll
> compute frame size */
> p_sys->i_state = STATE_HEADER;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_HEADER:
> /* Get FLAC frame header (MAX_FLAC_HEADER_SIZE bytes) */
> @@ -387,7 +387,7 @@ static block_t *Packetize(decoder_t *p_dec, block_t
> **pp_block)
> * The confusing part below is that sync code needs to be
> verified in case
> * it would appear in data, so we also need to check next
> frame header CRC
> */
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> {
> diff --git a/modules/packetizer/h264_nal.c
> b/modules/packetizer/h264_nal.c
> index 0cf35899ab..d4005dd9e5 100644
> --- a/modules/packetizer/h264_nal.c
> +++ b/modules/packetizer/h264_nal.c
> @@ -745,7 +745,7 @@ bool h264_get_dpb_values( const
> h264_sequence_parameter_set_t *p_sps,
> i_max_num_reorder_frames = 0; /* all IDR */
> break;
> }
> - /* fallthrough */
> + /* fall through */
> default:
> i_max_num_reorder_frames = h264_get_max_dpb_frames(
> p_sps );
> break;
> diff --git a/modules/packetizer/mlp.c b/modules/packetizer/mlp.c
> index 308e7fca04..4fefc0b5be 100644
> --- a/modules/packetizer/mlp.c
> +++ b/modules/packetizer/mlp.c
> @@ -326,7 +326,7 @@ static block_t *Packetize( decoder_t *p_dec,
> block_t **pp_block )
> /* Need more data */
> return NULL;
> }
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> /* New frame, set the Presentation Time Stamp */
> @@ -337,7 +337,7 @@ static block_t *Packetize( decoder_t *p_dec,
> block_t **pp_block )
> date_Set( &p_sys->end_date, p_sys->i_pts );
> }
> p_sys->i_state = STATE_HEADER;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_HEADER:
> /* Get a MLP header */
> @@ -360,7 +360,7 @@ static block_t *Packetize( decoder_t *p_dec,
> block_t **pp_block )
> break;
> }
> p_sys->i_state = STATE_NEXT_SYNC;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> /* Check if next expected frame contains the sync word */
> @@ -398,7 +398,7 @@ static block_t *Packetize( decoder_t *p_dec,
> block_t **pp_block )
> return NULL;
> }
> p_sys->i_state = STATE_SEND_DATA;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SEND_DATA:
> /* When we reach this point we already know we have enough
> diff --git a/modules/packetizer/mpeg4audio.c
> b/modules/packetizer/mpeg4audio.c
> index eaf9b545d5..3d99f50337 100644
> --- a/modules/packetizer/mpeg4audio.c
> +++ b/modules/packetizer/mpeg4audio.c
> @@ -1193,7 +1193,7 @@ static block_t *PacketizeStreamBlock(decoder_t
> *p_dec, block_t **pp_block)
> /* Need more data */
> return NULL;
> }
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> /* New frame, set the Presentation Time Stamp */
> @@ -1236,7 +1236,7 @@ static block_t *PacketizeStreamBlock(decoder_t
> *p_dec, block_t **pp_block)
> }
>
> p_sys->i_state = STATE_NEXT_SYNC;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> if (p_sys->bytestream.p_block == NULL) {
> @@ -1292,7 +1292,7 @@ static block_t *PacketizeStreamBlock(decoder_t
> *p_dec, block_t **pp_block)
> p_sys->i_header_size) != VLC_SUCCESS)
> return NULL; /* Need more data */
> p_sys->i_state = STATE_SEND_DATA;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SEND_DATA:
> /* When we reach this point we already know we have enough
> diff --git a/modules/packetizer/mpegaudio.c
> b/modules/packetizer/mpegaudio.c
> index 1398da0813..edac153658 100644
> --- a/modules/packetizer/mpegaudio.c
> +++ b/modules/packetizer/mpegaudio.c
> @@ -344,7 +344,7 @@ static block_t *DecodeBlock( decoder_t *p_dec,
> block_t **pp_block )
> /* Need more data */
> return NULL;
> }
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SYNC:
> /* New frame, set the Presentation Time Stamp */
> @@ -363,7 +363,7 @@ static block_t *DecodeBlock( decoder_t *p_dec,
> block_t **pp_block )
> }
> }
> p_sys->i_state = STATE_HEADER;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_HEADER:
> /* Get MPGA frame header (MPGA_HEADER_SIZE bytes) */
> @@ -408,7 +408,7 @@ static block_t *DecodeBlock( decoder_t *p_dec,
> block_t **pp_block )
> }
>
> p_sys->i_state = STATE_NEXT_SYNC;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> /* Check if next expected frame contains the sync word */
> @@ -547,7 +547,7 @@ static block_t *DecodeBlock( decoder_t *p_dec,
> block_t **pp_block )
> return NULL;
> }
> p_sys->i_state = STATE_SEND_DATA;
> - /* fallthrough */
> + /* fall through */
>
> case STATE_SEND_DATA:
> if( !(p_buf = GetOutBuffer( p_dec, &p_out_buffer )) )
> diff --git a/modules/packetizer/packetizer_helper.h
> b/modules/packetizer/packetizer_helper.h
> index dece985b24..decfdffae0 100644
> --- a/modules/packetizer/packetizer_helper.h
> +++ b/modules/packetizer/packetizer_helper.h
> @@ -155,7 +155,7 @@ static inline block_t *packetizer_Packetize(
> packetizer_t *p_pack, block_t **pp_
> return NULL; /* Need more data */
>
> p_pack->i_offset = 1; /* To find next startcode */
> - /* fallthrough */
> + /* fall through */
>
> case STATE_NEXT_SYNC:
> /* Find the next startcode */
> diff --git a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> index 34cdb6ae33..fe75ac27e1 100644
> --- a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> +++ b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> @@ -170,12 +170,12 @@ intf_sys_t::~intf_sys_t()
> case Stopped:
> // Generate the close messages.
> m_communication->msgReceiverClose( m_appTransportId );
> - /* fallthrough */
> + /* fall through */
> case Connecting:
> case Connected:
> case Launching:
>
> m_communication->msgReceiverClose(DEFAULT_CHOMECAST_RECEIVER);
> - /* fallthrough */
> + /* fall through */
> default:
> break;
> }
> @@ -1165,7 +1165,7 @@ vlc_tick_t intf_sys_t::getPlaybackTimestamp()
> case Paused:
> if( !m_played_once )
> return VLC_TICK_INVALID;
> - /* fallthrough */
> + /* fall through */
> case Playing:
> {
> assert( m_communication );
> diff --git a/modules/video_filter/ripple.c
> b/modules/video_filter/ripple.c
> index a190c35003..72f9a53c3b 100644
> --- a/modules/video_filter/ripple.c
> +++ b/modules/video_filter/ripple.c
> @@ -160,7 +160,7 @@ static picture_t *Filter( filter_t *p_filter,
> picture_t *p_pic )
> CASE_PACKED_YUV_422
> // Quick hack to fix u/v inversion occuring with 2
> byte pixel pitch
> i_pixel_pitch *= 2;
> - /* fallthrough */
> + /* fall through */
> CASE_PLANAR_YUV
> black_pixel = ( p_pic->i_planes > 1 && i_index ==
> Y_PLANE ) ? 0x00
>
> : 0x80;
> diff --git a/modules/video_filter/transform.c
> b/modules/video_filter/transform.c
> index 346a89c241..5b5434ebb7 100644
> --- a/modules/video_filter/transform.c
> +++ b/modules/video_filter/transform.c
> @@ -422,7 +422,7 @@ static int Open(vlc_object_t *object)
> (char *)&src->i_chroma);
> goto error;
> }
> - /* fallthrough */
> + /* fall through */
> case VLC_CODEC_YUYV:
> case VLC_CODEC_YVYU:
> sys->plane[0] = dsc->yuyv; /* 32-bits, not 16-bits! */
> diff --git a/modules/video_filter/wave.c b/modules/video_filter/wave.c
> index 9631a90db4..0e6ee26e8b 100644
> --- a/modules/video_filter/wave.c
> +++ b/modules/video_filter/wave.c
> @@ -149,7 +149,7 @@ static picture_t *Filter( filter_t *p_filter,
> picture_t *p_pic )
> CASE_PACKED_YUV_422
> // Quick hack to fix u/v inversion occuring with 2
> byte pixel pitch
> i_pixel_pitch *= 2;
> - /* fallthrough */
> + /* fall through */
> CASE_PLANAR_YUV
> black_pixel = ( p_pic->i_planes > 1 && i_index ==
> Y_PLANE ) ? 0x00
>
> : 0x80;
> diff --git a/modules/video_output/win32/d3d11_quad.c
> b/modules/video_output/win32/d3d11_quad.c
> index b1648cc342..869d954e9d 100644
> --- a/modules/video_output/win32/d3d11_quad.c
> +++ b/modules/video_output/win32/d3d11_quad.c
> @@ -1118,7 +1118,7 @@ void D3D11_UpdateViewport(d3d_quad_t *quad, const
> RECT *rect, const d3d_format_t
> quad->cropViewport[3] = quad->cropViewport[0];
> break;
> }
> - /* fallthrough */
> + /* fall through */
> case VLC_CODEC_I420:
> quad->cropViewport[1].TopLeftX =
> quad->cropViewport[0].TopLeftX / 2;
> quad->cropViewport[1].TopLeftY =
> quad->cropViewport[0].TopLeftY / 2;
> diff --git a/src/preparser/preparser.c b/src/preparser/preparser.c
> index 9c35bc12bd..f262183b10 100644
> --- a/src/preparser/preparser.c
> +++ b/src/preparser/preparser.c
> @@ -282,7 +282,7 @@ void input_preparser_Push( input_preparser_t
> *preparser,
> case ITEM_TYPE_PLAYLIST:
> if( !b_net || i_options &
> META_REQUEST_OPTION_SCOPE_NETWORK )
> break;
> - /* fallthrough */
> + /* fall through */
> default:
> if (cbs && cbs->on_preparse_ended)
> cbs->on_preparse_ended(item, ITEM_PREPARSE_SKIPPED,
> cbs_userdata);
> --
> 2.21.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
More information about the vlc-devel
mailing list