[vlc-devel] [PATCH] access: rdp: fix URI parsing

[Thomas Guillem]

On Mon, Mar 25, 2019, at 19:28, Simon Latapie wrote:
> ---
>  modules/access/rdp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/access/rdp.c b/modules/access/rdp.c
> index e8b2fc6fac..8a16a42038 100644
> --- a/modules/access/rdp.c
> +++ b/modules/access/rdp.c
> @@ -457,7 +457,7 @@ static int Open( vlc_object_t *p_this )
>  
>      /* Parse uri params for pre-connect */
>      vlc_url_t url;
> -    vlc_UrlParse( &url, p_demux->psz_location );
> +    vlc_UrlParse( &url, p_demux->psz_url );

Could you explain why this is needed ?

cf. documentation:
    char        *psz_url; /**< Full URL or MRL (can be NULL) */
    const char  *psz_location; /**< Location (URL with the scheme stripped) */

Localtion is the url with the scheme stripped, so this patch would cause url.psz_protocol to be valid but it is not used at all in this file.



>  
>      if ( !EMPTY_STR(url.psz_host) )
>          p_sys->psz_hostname = strdup( url.psz_host );
> -- 
> 2.11.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel